Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing VOLUME declaration #740

Closed
iaroslavscript opened this issue Nov 5, 2020 · 5 comments
Closed

Fix missing VOLUME declaration #740

iaroslavscript opened this issue Nov 5, 2020 · 5 comments
Labels
0crat/new enhancement New feature or request

Comments

@iaroslavscript
Copy link
Contributor

iaroslavscript commented Nov 5, 2020 •
edited

Dockerfile should have VOLUME declaration for persistent data storage and config file as it told in best-practices.

Please see my pull request #741

P.S. I had to move config file from /etc/artipie.yml to /etc/artipie/artipie.yml because it's almost impossible to declare volume as a file and not as directory.

P.P.S. Related to #75
@iaroslavscript iaroslavscript added the enhancement New feature or request label Nov 5, 2020
@0crat 0crat added the 0crat/new label Nov 5, 2020
@iaroslavscript iaroslavscript mentioned this issue Nov 5, 2020
Merged
iaroslavscript added a commit to iaroslavscript/artipie that referenced this issue Nov 9, 2020
@iaroslavscript
artipie#740 fix backward-compatibility
941c3c2
@olegmoz olegmoz closed this as completed in b8edf71 Nov 9, 2020
olegmoz added a commit that referenced this issue Nov 9, 2020
@olegmoz
Merge pull request #741 from iaroslavscript/740-fix-missing-volume-de…
59f1dcb 
…claration

fix #740
@olegmoz
Copy link
Contributor

olegmoz commented Nov 9, 2020

@rultor release, tag=0.12.1

@rultor
Copy link
Contributor

rultor commented Nov 9, 2020

@rultor release, tag=0.12.1

@olegmoz OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Nov 9, 2020

@rultor release, tag=0.12.1

@olegmoz Done! FYI, the full log is here (took me 2min)

@olegmoz
Copy link
Contributor

olegmoz commented Nov 9, 2020

@iaroslavscript new release is ready and available on DockerHub: https://hub.docker.com/layers/artipie/artipie/0.12.1/images/sha256-b62852a1cfff890e706adc290aecdebda6fab605154856c205c306bcfadbaeaa?context=explore

@0crat
Copy link

0crat commented Nov 9, 2020

Job gh:artipie/artipie#740 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0crat/new enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@olegmoz @rultor @iaroslavscript @0crat