Uninversal aws infrastructure #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@g4s8, can you review this PR? |
g4s8
suggested changes
Jul 29, 2020
There was a problem hiding this comment.
@Sammers21 why to create new terraform script for AWS infrastructure? We already have working scripts and you can modify it. New implementation doesn't have few important details, such as security groups to access instances via SSH, VPC configuration to setup private network for these instances. Also, we have a script for waiting instances boot for complete https://github.com/artipie/benchmarks/blob/master/files/wait-instance-init.sh
|
@g4s8, review the PR once again, please |
|
@g4s8, please, review the PR. |
|
@g4s8, review the PR, please. |
g4s8
suggested changes
Jul 31, 2020
|
@g4s8, review the PR once again, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add universal aws infrastructure with a purpose to be used in every benchmark
Related to #21