Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

refactor: use storages instead of settings storage #56

Merged
merged 17 commits into from
Dec 22, 2021
Merged

refactor: use storages instead of settings storage #56

merged 17 commits into from
Dec 22, 2021

Conversation

genryxy
Copy link
Contributor

@genryxy genryxy commented Dec 20, 2021

Part of artipie/artipie#321
Repository has storages which could differ from storage with repository settings therefore Storages was used to get this storage form Artipie module

genryxy and others added 17 commits June 10, 2021 17:50
Closes #39 - fixed 2 problems in ApiRepoUpdateSlice:
 1) parameters separator was expected to be ; instead of &
 2) storage settings were always expected to be yaml, but there also can be string for default value

PR: #40
Closes #39 - Body with repo configs should be url-decoded.

PR: #41
Closes #42 - simplified and fixed updating storage scenario in ApiRepoUpdateSlice.

On dashboard we always work with whole yaml repo settings, so there is no need to update section by section, we can simply rewrite the whole file after checking that required fields (type and storage) are present in the new version.
Added description for several repositories.

Issue: artipie/artipie#317
PR: #44
Handle errors in `ApiRepoUpdateSlice` (#45)

Closes: artipie/artipie#320
Added anaconda repository option to dashboard and configuration description.

Ticket: artipie/artipie#317
Clarified API reference link name.

Closes: #47
Part of artipie/artipie#965
Added rq line to get users in FromRqLine, corresponding test and updated http and asto.
Add slice to delete a repo. Added disabled test for this slice as it is necessary to implement delete operation in FakeConfigFile class.

Ticket: artipie/artipie#321
Added slice ApiRepoPostRtSlice for routing post requests by parsing body content. This class will be used in artipie module. Test will be added in next PR.

Ticket: artipie/artipie#321
 * Bumped ppom from 0.5.1 to 1.1.0
 * Bumped asto from v1.9.0 to v1.10.0
 * Bumped http-client from 0.3.2 to 0.3.6
 * Bumped vert-server from 0.4 to 0.5
Extract class for parsing body content for receiving some content.

Close: #50
Enable and a bit extend test for ApiRepoDeleteSlice and add test for ApiRepoPostRtSlice.

Ref: artipie/artipie#321
@genryxy genryxy requested review from a team and olenagerasimova and removed request for a team December 20, 2021 13:56
Copy link
Member

@olenagerasimova olenagerasimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genryxy thanks, looks good

@genryxy
Copy link
Contributor Author

genryxy commented Dec 21, 2021

@g4s8 could you please check/merge

@genryxy genryxy requested a review from g4s8 December 22, 2021 07:02
@g4s8 g4s8 merged commit 5695cf8 into artipie:master Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants