Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlAlter.java:45-46: Create separate proper unit-test for... #167

Closed
0pdd opened this issue May 8, 2020 · 7 comments
Closed

XmlAlter.java:45-46: Create separate proper unit-test for... #167

0pdd opened this issue May 8, 2020 · 7 comments

Comments

@0pdd
Copy link

0pdd commented May 8, 2020

The puzzle 144-e68f383c from #144 has to be resolved:

* @todo #144:30min Create separate proper unit-test for this class, now it is tested in the
* XmlPackagesFileTest#writesCorrectPackageCount(java.nio.file.Path) method.

The puzzle was created by olenagerasimova on 07-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented May 8, 2020

@g4s8/z please, pay attention to this issue

@g4s8
Copy link
Member

g4s8 commented May 8, 2020

@olenagerasimova are you going to fix it by yourself, or we can delegate it to 0crat developers?

@olenagerasimova
Copy link
Member

@g4s8 I think it would be convenient (or even necessary) to do it together with #164 and so please assign me this issue

@0crat
Copy link

0crat commented May 8, 2020

The job #167 assigned to @olenagerasimova/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0pdd 0pdd closed this as completed May 13, 2020
@0pdd
Copy link
Author

0pdd commented May 13, 2020

The puzzle 144-e68f383c has disappeared from the source code, that's why I closed this issue.

@0crat 0crat added the qa label May 13, 2020
@0crat
Copy link

0crat commented May 13, 2020

@sereshqua/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label May 13, 2020
@sereshqua
Copy link

@0crat quality good

@0crat 0crat added quality/good and removed qa labels May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants