Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpm.java:241-242: Extract repeating code from... #224

Closed
0pdd opened this issue Jun 3, 2020 · 10 comments
Closed

Rpm.java:241-242: Extract repeating code from... #224

0pdd opened this issue Jun 3, 2020 · 10 comments

Comments

@0pdd
Copy link

0pdd commented Jun 3, 2020

The puzzle 192-3e5a54da from #192 has to be resolved:

* @todo #192:30min Extract repeating code from updateBatch() and this method into private
* methods or classes. Also try refactor this method to make it easier to read/maintain.

The puzzle was created by @olenagerasimova on 02-Jun-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented Jun 3, 2020

@g4s8/z please, pay attention to this issue

@0crat
Copy link

0crat commented Jun 3, 2020

The job #224 assigned to @olegmoz/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @olegmoz/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

@olegmoz
Copy link
Contributor

olegmoz commented Jun 3, 2020

@g4s8 sorry, but may be you meant to assign @olenagerasimova ?

@g4s8
Copy link
Member

g4s8 commented Jun 3, 2020

@g4s8 sorry, but may be you meant to assign @olenagerasimova ?

@olenagerasimova what do you think?

@olenagerasimova
Copy link
Member

@g4s8 I do not mind to take this issue

@g4s8 g4s8 assigned olenagerasimova and unassigned olegmoz Jun 3, 2020
@0crat
Copy link

0crat commented Jun 3, 2020

@g4s8/z I see that you unassigned this issue; the order is still assigned to @olegmoz/z though; to cancel the order use refuse, as in §6

@0crat
Copy link

0crat commented Jun 3, 2020

The job #224 assigned to @olenagerasimova/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Jun 3, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Jun 4, 2020
g4s8 added a commit that referenced this issue Jun 5, 2020
#224 - extract repeating code to methods
@0pdd 0pdd closed this as completed Jun 5, 2020
@0pdd
Copy link
Author

0pdd commented Jun 5, 2020

The puzzle 192-3e5a54da has disappeared from the source code, that's why I closed this issue.

@0crat 0crat added the qa label Jun 5, 2020
@0crat
Copy link

0crat commented Jun 5, 2020

@sereshqua/z please review this job completed by @olenagerasimova/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jun 5, 2020
@sereshqua
Copy link

@0crat quality good

@0crat 0crat added quality/good and removed qa labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants