Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryOutputTest.java:88-90: Introduce class from this... #278

Closed
0pdd opened this issue Jun 19, 2020 · 17 comments · Fixed by #293
Closed

PrimaryOutputTest.java:88-90: Introduce class from this... #278

0pdd opened this issue Jun 19, 2020 · 17 comments · Fixed by #293
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented Jun 19, 2020

The puzzle 241-a350bc6d from #241 has to be resolved:

* @todo #241:30min Introduce class from this method: the method is copied from FilePackage
* class, we need to extract class from it, test it and use it at least in FilePackage,
* ModifiableMetadataTest and here.

The puzzle was created by olenagerasimova on 18-Jun-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0pdd referenced this issue Jun 19, 2020
#241 - added generated metadata files and PrimaryOutput test
@olenagerasimova
Copy link
Member

@0crat in

@0crat
Copy link

0crat commented Jun 19, 2020

@g4s8/z, @olenagerasimova/z please, pay attention to this issue

@0crat
Copy link

0crat commented Jun 19, 2020

The job #278 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@olenagerasimova
Copy link
Member

@olegmoz don't you mind taking this issue? We need to extract class from method and replace code duplication.

@olegmoz
Copy link
Contributor

olegmoz commented Jun 23, 2020

@olenagerasimova yes please, assign me

@0crat
Copy link

0crat commented Jun 23, 2020

@olenagerasimova/z I see that you unassigned this issue; the order is still assigned to @paulodamaso/z though; to cancel the order use refuse, as in §6

@olenagerasimova
Copy link
Member

@0crat refuse

@0crat
Copy link

0crat commented Jun 23, 2020

The job #278 assigned to @olegmoz/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @olegmoz/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

@olenagerasimova
Copy link
Member

@olegmoz please, implement headers obtaining as it's done in FilePackage.header() method, test has simplified version

@0crat
Copy link

0crat commented Jun 23, 2020

@0crat refuse (here)

@olenagerasimova The user @olegmoz/z resigned from #278, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link

0crat commented Jun 23, 2020

The job #278 assigned to @olegmoz/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @olegmoz/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

olegmoz referenced this issue in olegmoz/rpm-adapter Jun 25, 2020
olenagerasimova added a commit that referenced this issue Jun 25, 2020
#278 - Extracted FilePackageHeader from FilePackage
@0crat
Copy link

0crat commented Jun 25, 2020

Job #278 is not in the agenda of @olegmoz/z, can't set title

@0crat 0crat added the qa label Jun 25, 2020
@0crat
Copy link

0crat commented Jun 25, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@586d9f4c-3ecc-4a70-b164-2390bfcb7afb, thread: PQ-CT2E6TK9B
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 1 error(s) in XML document: -1:-1: Duplicate unique value [gh:artipie/rpm-adapter#278] declared for identity constraint of element "speed".

0.53.15: CID: 3ff6e4e4-f77b-4795-b959-32dc21010688, Type: "Order was finished"

@0crat
Copy link

0crat commented Jun 25, 2020

Job #278 is not in the agenda of @olegmoz/z, can't set title

@0crat
Copy link

0crat commented Jun 25, 2020

@sereshqua/z please review this job completed by @olegmoz/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality good

@olenagerasimova olenagerasimova added this to the Week 26 milestone Jun 26, 2020
@0crat
Copy link

0crat commented Jun 26, 2020

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@c7fc22bc-bc34-4b92-886c-5bb37239a1aa, thread: PQ-CT2E6TK9B
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 2 error(s) in XML document: -1:-1: cvc-pattern-valid: Value 'gh:Week 26' is not facet-valid with respect to pattern '[a-z]{2}:[A-Z0-9a-z.\-#/]+' for type 'milestoneID'.;-1:-1: cvc-complex-type.2.2: Element 'successor' must have no element [children], and the value must be valid.

0.53.15: CID: 4eaf8151-e696-4482-92a1-8e7de049c204, Type: "Job milestoned"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants