Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wrap XMLStreamException into IOException #323

Closed
olenagerasimova opened this issue Jul 6, 2020 · 1 comment · Fixed by #373
Closed

Don't wrap XMLStreamException into IOException #323

olenagerasimova opened this issue Jul 6, 2020 · 1 comment · Fixed by #373

Comments

@olenagerasimova
Copy link
Member

We have a lot of places where XMLStreamException is wrapped into IOException, but is does not seem right: XMLStreamException is

the base exception for unexpected processing errors

and does not have anything to do with I/O operations failure. Let's fix it by maybe introducing another exception for all possible error while working with xml files.
@olenagerasimova olenagerasimova mentioned this issue Jul 6, 2020
Merged
@olenagerasimova olenagerasimova mentioned this issue Oct 23, 2020
Closed
7 tasks
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 27, 2020
@olenagerasimova
#323 - created XmlException
f82d0ce
@olenagerasimova olenagerasimova mentioned this issue Oct 27, 2020
Merged
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 27, 2020
@olenagerasimova
#323 - serial suppressed
7cd416c
olenagerasimova added a commit that referenced this issue Oct 27, 2020
@olenagerasimova
Merge pull request #372 from olenagerasimova/323-create-xml-exception
a8a5d2c 
#323 - created XmlException
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 27, 2020
@olenagerasimova
#323 - use XmlException for errors with xml metadata instead of IOExc…
52f50c3 
…eption
@olenagerasimova olenagerasimova mentioned this issue Oct 27, 2020
Merged
olenagerasimova added a commit that referenced this issue Oct 27, 2020
@olenagerasimova
Merge pull request #373 from olenagerasimova/323
722e2a2 
#323 - use XmlException for errors with xml metadata
@0crat
Copy link

0crat commented Oct 27, 2020

Job gh:artipie/rpm-adapter#323 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#323 - use XmlException for errors with xml metadata olenagerasimova/rpm-adapter
2 participants
@olenagerasimova @0crat