Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty index xml input stream #415

Closed
olenagerasimova opened this issue May 31, 2021 · 3 comments · Fixed by #417
Closed

Empty index xml input stream #415

olenagerasimova opened this issue May 31, 2021 · 3 comments · Fixed by #417

Comments

@olenagerasimova
Copy link
Member

RpmMetadata.Remove and RpmMetadata.Append should properly handle the case, when empty index xml in provided as input stream. By empty index xml I mean valid xml for empty repository:

<?xml version="1.0" encoding="UTF-8"?>
<metadata xmlns="http://linux.duke.edu/metadata/other" packages="0"/>
g4s8 pushed a commit that referenced this issue Jun 1, 2021
Part of #415 - This PR fixes problem with empty index xml while appending rpms.

PR: #416
@g4s8 g4s8 closed this as completed in #417 Jun 2, 2021
g4s8 pushed a commit that referenced this issue Jun 2, 2021
Closes #415 - Corrected RpmMetadata.Remove() to work with empty indexes properly.

PR: #417
@olenagerasimova
Copy link
Member Author

@rultor release, tag=1.7

@rultor
Copy link

rultor commented Jun 2, 2021

@rultor release, tag=1.7

@olenagerasimova OK, I will release it now. Please check the progress here

@rultor
Copy link

rultor commented Jun 2, 2021

@rultor release, tag=1.7

@olenagerasimova Done! FYI, the full log is here (took me 10min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants