FilePackage.java:113-115: Create unit tests to verify...

[0pdd]

The puzzle 69-3c6bbf6c from #69 has to be resolved:

rpm-adapter/src/main/java/com/artipie/rpm/pkg/FilePackage.java

Lines 113 to 115 in 493153a

	* @todo #69:30min Create unit tests to verify that
	* FilePackage headers can parse headers and header range correctly,
	* can calculate file size and check-sums correctly.

The puzzle was created by @g4s8 on 08-Apr-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

[0crat]

@g4s8/z please, pay attention to this issue

[0crat]

The job #75 assigned to @carlosmiranda/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[0crat]

@carlosmiranda/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[carlosmiranda]

@0crat refuse

[0crat]

@0crat refuse (here)

@carlosmiranda The user @carlosmiranda/z resigned from #75, please stop working. Reason for job resignation: Order was cancelled

[0crat]

The job #75 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[ammaratef45]

@0crat refuse

[0crat]

@0crat refuse (here)

@ammaratef45 The user @ammaratef45/z resigned from #75, please stop working. Reason for job resignation: Order was cancelled

[0crat]

@0crat refuse (here)

@ammaratef45 Job refused in 19 hours - no penalty, see §6

[0crat]

The job #75 assigned to @HDouss/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[HDouss]

@0crat refuse

[0crat]

@0crat refuse (here)

@HDouss The user @HDouss/z resigned from #75, please stop working. Reason for job resignation: Order was cancelled

[0crat]

@0crat refuse (here)

@HDouss Job refused in 0 hours - no penalty, see §6

[0crat]

The job #75 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[victornoel]

@g4s8 I have two questions on this task:

• what is the meaning of testing size or checksum when it corresponds to copypasting the content of the checksum and size method in a test file? Aren't there more useful things to do? Maybe testing directly FilePackage would make more sense, no?
• what is header range? I don't see anything related to that in the class or interface behaviour my bad, I missed it, anyway, same question as above...

[g4s8]

@victornoel yes, your suggestions makes sense. This ticket is about verifying metadata parsing from RPM packages and increase coverage for that, since this part is one of the most central point in the logic.

[victornoel]

@0crat wait for #152 to be merged

[victornoel]

@g4s8 see #152, I added a todo there to convey this intention :)

[0pdd]

The puzzle 69-3c6bbf6c has disappeared from the source code, that's why I closed this issue.

[0pdd]

@0pdd 2 puzzles #154, #155 are still not solved.

[0crat]

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@0crat quality good

[0pdd]

@0pdd the puzzle #154 is still not solved; solved: #155.

[0pdd]

@0pdd all 2 puzzles are solved here: #154, #155.