Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build instructions somewhat unclear about which make steps to run #99

Closed
jordigh opened this issue Aug 14, 2019 · 0 comments · Fixed by #101
Closed

Build instructions somewhat unclear about which make steps to run #99

jordigh opened this issue Aug 14, 2019 · 0 comments · Fixed by #101
Assignees
@artivis
Labels
Documentation

Comments

@jordigh
Copy link

jordigh commented Aug 14, 2019

The library is header-only. This means that there is nothing to build at installation time.

The documentation suggests running make after cmake, but unless we are building the tests and examples, this is pointless.

Morever, the build instructions do not indicate a make install step. This is necessary so that manif will be found according to the instructions in the "Use Manif in your project" section of the Readme.
@jordigh jordigh changed the title Build instructions somewhat unclear Build instructions somewhat unclear about which make steps to run Aug 14, 2019
@jordigh jordigh mentioned this issue Aug 14, 2019
Closed
54 tasks
@artivis artivis self-assigned this Aug 14, 2019
artivis added a commit that referenced this issue Aug 14, 2019
@artivis
Fix build/install instruction in readme
9ca5587 
  Fix #99
@artivis artivis mentioned this issue Aug 14, 2019
Merged
artivis added a commit that referenced this issue Aug 19, 2019
@artivis
Fixes for joss review (#101)
27c5d51 
* Fix build/install instruction in readme
  Fix #99
* Update/fix typo README.md 
* remove 'constexpr void' function altogether
  Fix #98
* readme install eigen on osx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artivis artivis

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes following jordigh review artivis/manif
2 participants
@jordigh @artivis