Add some Map tests #127
Merged
Add some Map tests #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #127 +/- ##
==========================================
+ Coverage 98.21% 98.23% +0.01%
==========================================
Files 36 37 +1
Lines 1123 1130 +7
==========================================
+ Hits 1103 1110 +7
Misses 20 20 |
artivis
force-pushed
the
feature/map_test
branch
from
a1d3a68
to
09e81a5
Compare
|
@joansola PR ready for review. |
joansola
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some common
Eigen::Map-related tests to all groups.Those tests highlighted that calling
random()on aMap<Group>object was broken (not compiling).