Add Endpoint for Current Timestamp in ISO Format #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devbuddytest[bot]](https://avatars.githubusercontent.com/in/823873?s=60&v=4){kind=small}
artmoskvin
reviewed
Feb 23, 2024
| assert response.status_code == 200 | ||
| # This test checks if the response is in ISO format by trying to parse it. | ||
| # If parsing fails, the test will fail. | ||
| datetime.fromisoformat(response.json()) |
There was a problem hiding this comment.
@devbuddytest this test fails because we need to import datetime
There was a problem hiding this comment.
You're right, I missed importing datetime in the test file. I'll add the necessary import statement to tests/test_api.py to ensure the test passes. Thank you for pointing that out! I'll update the code and push the changes.
There was a problem hiding this comment.
I've added the necessary import statement for datetime in the tests/test_api.py file. This should resolve the issue with the failing test. Could you please review the changes again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new endpoint
/timestampthat returns the current timestamp in ISO format. It also includes a unit test to ensure the endpoint behaves as expected.