Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Syntax Highlight of CMake Variable Reference #62

Closed
tvp-naubry opened this issue Mar 14, 2024 · 3 comments
Closed

Problem with Syntax Highlight of CMake Variable Reference #62

tvp-naubry opened this issue Mar 14, 2024 · 3 comments
Assignees

Comments

@tvp-naubry
Copy link

There is a visual conflict problem with CMake variables in themes with high contrast (presumably the JetBrains Dark Mode theme is not affected).

Disabling the CMake Plus / CMake simple highlighter plugin makes the problem disappear.

Here is an example of what I get with a CMake variable using the "One Dark Vivid" theme:
CleanShot 2024-03-14 at 13 25 29@2x
CleanShot 2024-03-14 at 13 28 00@2x

I'm not sure if this is a plugin issue, but if anyone has encountered the same problem and found a solution, I would be grateful!

@ArtsiomCh ArtsiomCh self-assigned this Mar 14, 2024
@tvp-naubry
Copy link
Author

tvp-naubry commented Mar 15, 2024

Note: I don't seem to have the problem on Windows. I found the problem on my MacBook Pro (macOS Sonoma).

EDIT:
I have the same problem on Windows.
I had the CMake Plus plugin deactivated and hadn't noticed this. Probably a bad synchronization of my IDE settings...
So sorry for the wrong indication: the problem occurs on macOS and Windows.

@ArtsiomCh
Copy link
Owner

Thanks for reporting!
Reproduced with One Dark Theme.
Will try to produce fix soon.
For now use next workaround: set the same color (font and it attributes could be different) for "CMake variable reference" and "Local variable reference" in

Settings > Editor > Color Scheme > CMake additional syntax

image

@ArtsiomCh
Copy link
Owner

Fixed in upcoming 241.1.1 version
Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants