New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-release #8
Conversation
( I've just given the engineering team write access to the repo 👍 ) |
c848165
to
5bd9404
Compare
So, I'm going to do the work here, but I ain't mergin' this one, ha. |
A few things here... I moved the CI over to Circle. I know it's massively more complex, but it brings it in line with our other setups. I added the danger job to the circle config. May need to tweak the caching a little bit b/c the CI isn't going to actually run until that's merged into master. I could technically pull it out into a separate PR (likely the right thing to do), but being as it's pretty much a copy and paste of palette's setup I'm reasonably certain it'll work fine. |
@@ -5,10 +5,13 @@ | |||
"main": "build/index.js", | |||
"author": "Eloy Durán <eloy.de.enige@gmail.com> & Art.sy Inc", | |||
"license": "MIT", | |||
"publishConfig": { | |||
"registry": "https://registry.npmjs.org/" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're using yarn it defaults to their alias registry and always fails. Took @orta a minute to track that one down originally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to Circle or Auto?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto. It's from this commit artsy/reaction@46b686c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh cool 👍
Adds auto-release as a replacement for
semantic-release
.(Will remove release-it in a follow-up PR.)
Related: