Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-release #8

Merged
merged 5 commits into from Jan 9, 2019
Merged

Add auto-release #8

merged 5 commits into from Jan 9, 2019

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 4, 2019

Adds auto-release as a replacement for semantic-release.

(Will remove release-it in a follow-up PR.)

Related:

@orta
Copy link
Contributor

orta commented Jan 4, 2019

( I've just given the engineering team write access to the repo 👍 )

@zephraph
Copy link
Contributor

zephraph commented Jan 6, 2019

So, I'm going to do the work here, but I ain't mergin' this one, ha.

@zephraph
Copy link
Contributor

zephraph commented Jan 6, 2019

A few things here...

I moved the CI over to Circle. I know it's massively more complex, but it brings it in line with our other setups. I added the danger job to the circle config. May need to tweak the caching a little bit b/c the .jest directory isn't going to be cached in this current setup (and I'm assuming that's important?).

CI isn't going to actually run until that's merged into master. I could technically pull it out into a separate PR (likely the right thing to do), but being as it's pretty much a copy and paste of palette's setup I'm reasonably certain it'll work fine.

@@ -5,10 +5,13 @@
"main": "build/index.js",
"author": "Eloy Durán <eloy.de.enige@gmail.com> & Art.sy Inc",
"license": "MIT",
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're using yarn it defaults to their alias registry and always fails. Took @orta a minute to track that one down originally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to Circle or Auto?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto. It's from this commit artsy/reaction@46b686c.

Copy link
Member Author

@damassi damassi Jan 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh cool 👍

@zephraph
Copy link
Contributor

zephraph commented Jan 9, 2019

@orta, @damassi what do you thing? Good to merge?

@zephraph zephraph merged commit e698235 into artsy:master Jan 9, 2019
@damassi damassi deleted the add-auto-release branch January 9, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants