Fix OSS builds #2398
Merged
Fix OSS builds #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
reviewed
Jul 16, 2017
|
|
||
|
|
||
| // For OSS builds | ||
| if ([DSN isEqualToString:@"-"]) { return self; } |
There was a problem hiding this comment.
I’m sightly worried that this may lead to somebody accidentally making a build with - set and is submitting that to the store. Is there another more reliable to differentiate an OSS build from others?
There was a problem hiding this comment.
We have checks for this in the Fastfile 👍 - https://docs.fastlane.tools/actions/#verify_pod_keys
Our build will fail if they are 1 char long
There was a problem hiding this comment.
We obviously have done this in the past - and so we built it into Fastlane ;)
|
Updates the reference for ARMasonry - ashfurrow/ARCollectionViewMasonryLayout@a9dc52b...f22180d While the version number is bumped, the only real changes are documentation ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2397