Use the ARTopMenuViewController to turn on/off scrolls to top on views

[orta]

This is not comprehensive, but covers a good chunk of our use cases. Essentially we would have multiple scrollviews with scrollsToTop enabled, which means it doesn't work at all. This covers most cases, a few view controllers do not conform to the ARMenuAwareViewControllerprotocol, and so we cannot turn those off. Which may mean it's going to occasionally show.

The real fix as noted in #1891 is to remove the bandage and use apples tab view controller instead of our custom one.

[ArtsyOpenSource]

	1 Error
🚫	Tests have failed, see below for more information.

	1 Warning
⚠️	Detected some Swift building time outliers

Time	Class	Function
190.8ms	SwiftyJSON.swift	get {}
163.3ms	WebSocket.swift	private func processRawMessage(buffer: UnsafePointer, bufferLen: Int)
86.3ms	LiveAuctionLotViewController.swift	@objc override func viewDidLoad()
73.9ms	Observable.swift	private final func nextTokenHash() -> Int
69.7ms	AuctionLotMetadataStackScrollView.swift	required init(viewModel: LiveAuctionLotViewModelType, salesPerson: LiveAuctionsSalesPersonType, sideMargin: String)
68.2ms	LiveAuctionsAdminViewController.swift	@objc override func viewDidLoad()
62.2ms	UIViewController+BlurredStatusView.swift	func ar_presentBlurredOverlayWithTitle(title: String, subtitle: String, buttonState: BlurredStatusOverlayViewCloseButtonState = default)
60.4ms	UIViewController+BlurredStatusView.swift	(closure)

Tests:

Classname	Name
ARTabViewSpec	test_sets_current_and_previous_view_index
ARTabViewSpec	test_correctly_shows_a_navigation_controller__at_first_index
ARTabViewSpec	test_correctly_shows_a_navigation_controller__at_another_index
ARTabViewSpec	test_correctly_sets_the_child_view_controller
ARTabViewSpec	test_sends_appearance_message_to_child_view_controller__viewDidLoad
ARTabViewSpec	test_sends_appearance_message_to_child_view_controller__viewWillAppear
ARTabViewSpec	test_sends_appearance_message_to_child_view_controller__viewDidAppear
ARTabViewSpec	test_sends_appearance_message_to_child_view_controller__viewWillDisappear
ARTabViewSpec	test_sends_appearance_message_to_child_view_controller__viewDidDisappear
ARTopMenuViewControllerSpec	test_as_iphone
ARTopMenuViewControllerSpec	test_as_ipad
ARTopMenuViewControllerSpec	test_as_iphone_2
ARTopMenuViewControllerSpec	test_as_ipad_2
ARTopMenuViewControllerSpec	test_navigation__feed__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__animates_popping
ARTopMenuViewControllerSpec	test_navigation__feed__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__does_not_change_tab
ARTopMenuViewControllerSpec	test_navigation__browse__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__animates_popping
ARTopMenuViewControllerSpec	test_navigation__browse__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__does_not_change_tab
ARTopMenuViewControllerSpec	test_navigation__browse__tab_behavior__when_presenting_a_root_view_controller__when_not_on_the_selected_tab__changes_tabs_in_an_animated_fashion
ARTopMenuViewControllerSpec	test_navigation__favorites__logged_in__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__animates_popping
ARTopMenuViewControllerSpec	test_navigation__favorites__logged_in__tab_behavior__when_presenting_a_root_view_controller__when_already_on_the_selected_tab__does_not_change_tab
ARTopMenuViewControllerSpec	test_navigation__favorites__logged_in__tab_behavior__when_presenting_a_root_view_controller__when_not_on_the_selected_tab__changes_tabs_in_an_animated_fashion

Generated by 🚫 danger

[alloy]

The code looks good to me. It’s a bit hard to judge the logic, but it seems like you did take care of some testing, so 👍