@orta => Tries to fix #103 and various related tickets. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also does the weak->strong dance in the right order.
|
🎱 |
|
For completeness sake, here is a session of where I try to simulate the crash, as I haven’t been able to reproduce it. void * -[UIScrollView _getDelegateZoomView](void * self, void * _cmd) {
r14 = self;
rbx = r14->_zoomView;
if (rbx == 0x0) {
rax = [r14->_delegate respondsToSelector:@selector(viewForZoomingInScrollView:)];
LODWORD(rbx) = 0x0;
if (LOBYTE(rax) != 0x0) {
rbx = [r14->_delegate viewForZoomingInScrollView:r14];
LODWORD(rax) = *(int32_t *)__UIApplicationLinkedOnVersion;
if (LODWORD(rax) != 0x0) {
LODWORD(rax) = *(int32_t *)__UIApplicationLinkedOnVersion;
LOBYTE(rax) = LODWORD(rax) > 0x4ffff ? 0x1 : 0x0;
}
else {
rax = ___UIApplicationLinkedOnOrAfter(0x50000);
}
if ((LOBYTE(rax) != 0x0) && (rbx == r14)) {
rdx = **NSGenericException;
[NSException raise:rdx format:@"The view returned from viewForZoomingInScrollView: must be a subview of the scroll view. It can not be the scroll view itself."];
}
}
}
rax = rbx;
return rax;
} |
This was referenced Feb 20, 2015
alloy
added a commit
that referenced
this pull request
Feb 20, 2015
|
Alloy, you're mind blowing. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also does the weak->strong dance in the right order.
As discussed I will be doing a bit more investigating, but I think what's happening is:
delegateproperty isassignnotweak.