-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): enable hermes #8789
Merged
Merged
feat(iOS): enable hermes #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
force-pushed
the
gkartalis/hermes-ios-69
branch
from
June 2, 2023 16:04
0edf628
to
175fcd7
Compare
11 tasks
…NotMerge (#8741) refactor: remove bundle-js job and move bundling to fastlane
gkartalis
force-pushed
the
gkartalis/hermes-ios-69
branch
from
June 5, 2023 16:44
284151d
to
4d237e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Re-enabling hermes on iOS to tryout the solution from sentry team.
Sourcemaps now work. Got rid of the culprit that was breaking our sourcemaps
index.tests.ios.js
that wasn't used anywhere 🤷♂️related issue on Sentry
Also tested out the sourcemaps here after the removal of
index.tests.ios.js
to confirm the fix ✅PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.