Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): enable hermes #8789

Merged
merged 10 commits into from
Jun 5, 2023
Merged

feat(iOS): enable hermes #8789

merged 10 commits into from
Jun 5, 2023

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented May 31, 2023

This PR resolves []

Description

Re-enabling hermes on iOS to tryout the solution from sentry team.

Sourcemaps now work. Got rid of the culprit that was breaking our sourcemaps index.tests.ios.js that wasn't used anywhere 🤷‍♂️

related issue on Sentry

Also tested out the sourcemaps here after the removal of index.tests.ios.js to confirm the fix ✅

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

  • enable hermes - gkartalis

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis
Copy link
Member Author

It's alive https://artsynet.sentry.io/issues/4229264611/events/c2d6d829cf584456835e039b0950c52e/?project=5867225

@gkartalis gkartalis assigned damassi and unassigned gkartalis Jun 5, 2023
@damassi damassi merged commit 0fc0666 into main Jun 5, 2023
@damassi damassi deleted the gkartalis/hermes-ios-69 branch June 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants