refactor(WIP): remove bundle-js job and move bundling to fastlane #doNotMerge #8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
changed the title
| paths: | ||
| - dist/main.jsbundle | ||
| - dist/main.jsbundle.map | ||
| - dist/assets |
There was a problem hiding this comment.
Lets closely monitor CI time here!
This was referenced May 23, 2023
gkartalis
added a commit
that referenced
this pull request
Jun 2, 2023
…NotMerge (#8741) refactor: remove bundle-js job and move bundling to fastlane
gkartalis
added a commit
that referenced
this pull request
Jun 5, 2023
…NotMerge (#8741) refactor: remove bundle-js job and move bundling to fastlane
damassi
pushed a commit
that referenced
this pull request
Jun 5, 2023
* feat(iOS): enable hermes * fix: add sourcemap_file flag * fix: execute rights to scripts * feat: add sourcemap file flag * refactor(WIP): remove bundle-js job and move bundling to fastlane #doNotMerge (#8741) refactor: remove bundle-js job and move bundling to fastlane * fix: add use_hermes flag * build: refresh ci cache * fix: add correct entry file * chore: remove index.test.ios.js file and use index.ios.js * chore: delete index.tests.ios.js file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves MOPLAT-771
Description
build-test-js(which is NOT needed) and might speed things up when running CI checksPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.