@craigspaeth => Accessible articles #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eessex
force-pushed
the
accessible-articles
branch
4 times, most recently
from
6913c7b
to
bd9f43b
Compare
eessex
force-pushed
the
accessible-articles
branch
from
bd9f43b
to
513d4ad
Compare
craigspaeth
approved these changes
Aug 17, 2017
| @@ -10,19 +10,22 @@ mixin share(description, media, url) | |||
| href="https://www.facebook.com/sharer/sharer.php?u=#{url}", | |||
| target='_blank' | |||
| ): i.icon-facebook-f.icon-in-table | |||
| span.screen-reader-text Post to Facebook | |||
| @@ -11,6 +11,14 @@ | |||
| search-bar-input-placeholder() | |||
| color white | |||
|
|
|||
| .screen-reader-text // hide text only for screen-readers | |||
There was a problem hiding this comment.
👍 nice—this is a clever way to feed content to screen readers.
|
Woot! ❤️ that you've picked this for Hackathon. Not the most glamorous technical challenge, but definitely a great thing to do and so in line with Artsy's mission to make art as accessible as music! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to articles and the main layout will improve accessibility and use with screen-readers. Problems were identified using error reports generated by the pa11y library.
.screen-reader-text)altattr for all article images