-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore ability to remove cents from amounts #27
Conversation
@dblock updated but GH isn't letting me re-request a review for whatever reason 🤷 |
I missed this for some reason (GH notifications 😠 ), sorry about that. Update README, and maybe we can add an UPGRADING file like https://github.com/ruby-grape/grape/blob/master/UPGRADING.md that describes this change? Also could use another (co)maintainer on this, want in @agrberg? Drop me a note to dblock[at]dblock[dot]org with your rubygems username. |
@dblock added Happy to help with this gem as well. I'm also a minor co-maintainer on your https://github.com/dblock/iex-ruby-client/ gem as well 🙌 For whatever reason I still cannot request a re-review so I'll be emailing you as well. |
Can we add @agrberg as a co-maintainer and give him rubygems access to make a release? |
@agrberg we ended up needing your changes for something at Artsy so I released the new version. Thank you so much for your contributions here! |
I wasn't able to find an explicit reason to remove this feature when making the breaking change in #20 so I'm adding it back as another library depends on the
no_cents
option toMoney#format
.