Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore ability to remove cents from amounts #27

Merged
merged 3 commits into from
Jan 6, 2022
Merged

restore ability to remove cents from amounts #27

merged 3 commits into from
Jan 6, 2022

Conversation

agrberg
Copy link
Contributor

@agrberg agrberg commented Oct 15, 2021

I wasn't able to find an explicit reason to remove this feature when making the breaking change in #20 so I'm adding it back as another library depends on the no_cents option to Money#format.

lib/money_helper.rb Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
lib/money_helper.rb Outdated Show resolved Hide resolved
@agrberg
Copy link
Contributor Author

agrberg commented Oct 18, 2021

@dblock updated but GH isn't letting me re-request a review for whatever reason 🤷

@dblock
Copy link
Collaborator

dblock commented Dec 23, 2021

I missed this for some reason (GH notifications 😠 ), sorry about that.

Update README, and maybe we can add an UPGRADING file like https://github.com/ruby-grape/grape/blob/master/UPGRADING.md that describes this change?

Also could use another (co)maintainer on this, want in @agrberg? Drop me a note to dblock[at]dblock[dot]org with your rubygems username.

@agrberg
Copy link
Contributor Author

agrberg commented Jan 3, 2022

@dblock added UPGRADEING.md as requested and broke out the 3.0.0 changes from the 2.0.0 changes for easier visibility.

Happy to help with this gem as well. I'm also a minor co-maintainer on your https://github.com/dblock/iex-ruby-client/ gem as well 🙌

For whatever reason I still cannot request a re-review so I'll be emailing you as well.

@joeyAghion
Copy link
Contributor

@dblock you're in!

@agrberg thanks for the contribution. Glad to see that the library is useful for you.

@joeyAghion joeyAghion merged commit 3d244fd into artsy:main Jan 6, 2022
@dblock
Copy link
Collaborator

dblock commented Jan 6, 2022

Can we add @agrberg as a co-maintainer and give him rubygems access to make a release?

@agrberg agrberg deleted the restore_money_format branch January 6, 2022 19:33
@annacarey
Copy link

@agrberg we ended up needing your changes for something at Artsy so I released the new version. Thank you so much for your contributions here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants