Polish navigation #215
Polish navigation #215
Conversation
damassi
force-pushed
the
more-polish
branch
2 times, most recently
from
1d26cbd
to
695de78
Compare
| @@ -79,6 +80,7 @@ | |||
| "@babel/core": "^7.2.2", | |||
| "@mdx-js/mdx": "^0.16.6", | |||
| "@mdx-js/tag": "^0.16.6", | |||
| "@reach/router": "^1.2.1", | |||
There was a problem hiding this comment.
Gatsby uses @reach/router under the hood so we can tap into all of its features if need be.
|
Deploy preview for artsy-palette ready! Built with commit 97d381a |
| const NavLink = styled(NavLinkWrapper)` | ||
| cursor: pointer; | ||
|
|
||
| &&.isActive { |
There was a problem hiding this comment.
&& in styled-components forces higher specificity.
|
Deploy preview for artsy-palette ready! Built with commit 695de78 |
| Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor | ||
| incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis | ||
| nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. | ||
|
|
There was a problem hiding this comment.
In terms of MDX, note that i'm interpolating markdown inside of of a JSX <Tab> component; however, the markdown has to be left justified for it to behave properly.
Being able to mix and match like this is so totally 👌 -- JSX as more sane version of short-codes.
Good idea, mdx.
|
Deploy preview for artsy-palette ready! Built with commit a5f3622 |
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| name: Utilities | |||
| order: 5 | |||
| order: 9 | |||
There was a problem hiding this comment.
I can't think of a more intelligent way to page order than this. Anyone have any suggestions? This is pretty simple / straightforward but seems like there might be a better way.
There was a problem hiding this comment.
Yeah, this is how I always end up doing it TBH
|
looking way slicker 👍 |
|
Thinking we can probably hook something like https://getgrav.org up for editing the docs. There are so many options these days.... |
@zephraph @orta - Ok Palette is basically done! 🎉Just need to add content styles as we start adding content. I dropped a message in #design-channel with an update.
Remaining items:
apollo-clirunning to generate typescript graphql typesOther than ^ and likely some things i'm forgetting its pretty much a wrap.