Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add a rule where every PR should include body text #5

Closed
orta opened this issue Aug 25, 2017 · 0 comments
Closed

RFC: Add a rule where every PR should include body text #5

orta opened this issue Aug 25, 2017 · 0 comments

Comments

@orta
Copy link
Contributor

orta commented Aug 25, 2017

Proposal:

It's possible to make a PR without any additional context. We should request that anyone making a PR with an empty body should add some text.

Reasoning

PR metadata is an important part of understanding how/why something happened later on, skipping a writeup or a quick link to a slack conversation makes it much harder to grok Artsy as a collection of systems.

Exceptions:

None that I can think of today? I was wondering about a revert PR, but even those could do with a "why".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant