Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make addPatchLabel global #91

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Make addPatchLabel global #91

merged 1 commit into from
Jan 4, 2019

Conversation

damassi
Copy link
Member

@damassi damassi commented Jan 4, 2019

Related artsy/reaction#1779

Moves addPatchLabel into the global namespace so that repos containing an .autorc can be evaluated.

@orta
Copy link
Contributor

orta commented Jan 4, 2019

ah, looks like my PR breaks this - sorry

@damassi
Copy link
Member Author

damassi commented Jan 4, 2019

I rebased 👍

@@ -3,7 +3,7 @@ import { danger } from "danger"
export const labels = {
Patch: {
color: "E0E4CC",
description: "A deploy for bug fixes",
description: "A deploy for bug fixes or minor changes",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this a little more accurate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - good point!

@orta
Copy link
Contributor

orta commented Jan 4, 2019

Cool, great.

@orta orta merged commit 6596e60 into master Jan 4, 2019
@damassi damassi deleted the make-addPatchLabel-global branch January 4, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants