@craigspaeth => Distribute Instant Articles via FB API #916
Conversation
|
My latest commit separates some of the bloat in save.coffee and moves it to a distribute.coffee. I've put Search, Instant Articles, and Sailthru stuff in there. Also I got the rendering bit to work but there's definitely cleanup potential there. Let me know if you have any questions on these parts! |
I'll probably spend at least a part of my 14 hour flight working on the above haha, but just wanted to get a checklist going for visibility. |
| moment = require 'moment' | ||
| particle = require 'particle' | ||
|
|
||
| @distributeArticle = (article, cb) => |
There was a problem hiding this comment.
👍 for extracting these common functions out to its own module.
kanaabe
changed the title
|
All the tests are now in. However this still needs a final gloss-over/polish on my end so I'll ping when ready! |
|
Okie dokes @craigspaeth, this PR is now ready for review. |
|
|
||
| include mixins | ||
|
|
||
| html(lang="en" prefix="op: http://media.facebook.com/op#") |
There was a problem hiding this comment.
👍 at first it seemed a little weird that we're rendering jade templates from the API app, but I think it makes total sense for the use case.
| moment = require 'moment' | ||
| cheerio = require 'cheerio' | ||
|
|
||
| module.exports = class Article extends Backbone.Model |
There was a problem hiding this comment.
👍 clever use of an API Backbone model here!
| moment = require 'moment' | ||
| particle = require 'particle' | ||
| cloneDeep = require 'lodash.clonedeep' | ||
|
|
There was a problem hiding this comment.
👌 well done separating out this distribute module.
| article = new Article cloneDeep article | ||
| return cb() unless article.isEditorial() | ||
| article.prepForInstant() | ||
| jade.renderFile 'api/apps/articles/components/instant_articles/index.jade', |
|
👏 great job! The code is very clean and clear. It puts a smile on my face seeing how much this highlights the effectivness of universal JS even beyond the typical "optimizing initial render" use case. Nice use of the same tools (Backbone, Jade, Cheerio, etc.) to solve a server-side/API problem. Very cool 💯 |
No description provided.