Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely eliminate unicode transcribing capabilities? #1178

Closed
drkameleon opened this issue Apr 28, 2023 · 2 comments · Fixed by #1569
Closed

Completely eliminate unicode transcribing capabilities? #1178

drkameleon opened this issue Apr 28, 2023 · 2 comments · Fixed by #1569
Assignees
Labels
enhancement New feature or request open discussion Open discussion about features/ideas/suggestions stale

Comments

@drkameleon
Copy link
Collaborator

drkameleon commented Apr 28, 2023

I've been looking into Arturo's binary size (and what the different components "weigh").

Apparently, there is one concrete feature that could be accounting for close to 25% of the binary size that is... barely used (on my Mac, out of ~9MBs, 2MB is due to the unidecode-related features)

So, where do we currently use it?

  • In convertToAscii in the Strings helper, which is in turn used in the Converters module (only for as.ascii)
  • In the unisort helper, or basically when we try to sort.ascii (which I am not even sure what it actually does lol)

In a few words: we barely use it and even I have personally never used it.

How do we solve this?

One way - and the "easiest" one by far would be to simply eliminate it.

Another idea would be to make this into a module/package, once Arturo's package system is ready. (as a matter of fact, it could be a very nice idea of a first experiment/package)

Another idea would be to make it so that the actual data is not loaded until we need it (e.g. via loadUnidecodeTable). The problem is where is this data supposed to come from? Will this be a dependency? A file in Arturo's installation folder?

In any case, wasting 2 out of 9 MB for that doesn't make any sense to me. (Being batteries-included is one thing and I'm all for that, but that's pretty much like packing Brittanica... just-in-case somebody needs it lol).

@drkameleon drkameleon added enhancement New feature or request open discussion Open discussion about features/ideas/suggestions labels Apr 28, 2023
@drkameleon drkameleon self-assigned this Apr 28, 2023
@RickBarretto
Copy link
Collaborator

RickBarretto commented Apr 28, 2023

Another idea would be to make this into a module/package, once Arturo's package system is ready.

I particularly like this option.

I never used this, but I know that it may be important for some cases where you want to communicate with older applications and libraries. But I think these are rare cases...

Copy link

stale bot commented Dec 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request open discussion Open discussion about features/ideas/suggestions stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants