Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Callbacks #40

Open
Daveismus opened this issue Aug 19, 2020 · 5 comments
Open

Fix Callbacks #40

Daveismus opened this issue Aug 19, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Daveismus
Copy link

I think the callbacks needs still to be fixed.
Can someone say, why or what is broken with monitoring/callbacks?
Maybe I can help then.

@arturtamborski
Copy link
Owner

Yea, this stuff is kinda broken. I'll allow for contributions but only after #41 gets merged. You can start working on it if you want but it's not stable yet, so that might end up with more frustrations than its worth.

@Daveismus
Copy link
Author

Can you tell me what exactly is broken, because I tried the callback and for me, it worked?

@arturtamborski
Copy link
Owner

arturtamborski commented Aug 25, 2020

I can't tell you exactly what is not working because I haven't written tests for Monitor/reactive parts of the library. The readme states that automatic updates from motion to python are not working.

You can test it by doing the steps below:

  • create a block
  • set some value
  • modify the value by hand on the notion page
  • notice that the new value is not shown in python (i.e. the representation did not refresh automatically)

I'm also not sure if the long polling works, never tested that feature.

Good news is that I just finished that nasty rewrite so I'm now working on getting the last missing bits in shape for a final release.

@Daveismus
Copy link
Author

In a previous version Jamie used websockets instead of long polling. Maybe this can be reused. I will look into it in the next days maybe I get some ideas

@arturtamborski arturtamborski self-assigned this Sep 13, 2020
@arturtamborski arturtamborski added the bug Something isn't working label Sep 18, 2020
@Daveismus
Copy link
Author

I just checked jamalex version of callbacks works right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants