Feature: more intuitive radius (SVG) #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's very unintuitive to have the the radius parameters be an absolute size instead of a percentage, like 60%, 40%, etc. At least for SVGs.
aruZeta
added
the
feature
|
Will have to fix the that action. |
aruZeta
added a commit
that referenced
this pull request
Sep 10, 2022
It already gets the pushed commit, and fixes an issue found in #23.
|
That did the trick |
|
This makes sense to me :) Thank you. |
aruZeta
force-pushed
the
feature/more-intuitive-radius/1
branch
from
4d21394
to
18806bf
Compare
|
I will wait till enthusiast shares his opinion on this, and also I would like to ask if this should be released to 2.0.0 or 1.1.0, I don't know if this is actually breaking backwards compatibility or not (I mean, it breaks rounded SVGs written before this PR, but is it that huge of a break? I'm trying to follow https://semver.org/). And also the same goes to the SVG class names changes. |
|
Much better! |
|
Okay then I will merge this into develop and next release will be 2.0.0. Main breaking changes will be (for the moment):
|
aruZeta
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's very unintuitive to have the the radius parameters be an absolute size instead of a percentage, like 60%, 40%, etc. At least for SVGs, where
rxwill always be a value from 0 to 0.4 for modules since it's a vector.I'm not making the commit directly to develop since I want to know what you guys think about this.
Mainly @enthus1ast @EyeCon @tandy-1000