Feature: custom module separation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: There is a bug with the generated C code, where ranges make it not work with the default value of `moSep`, so those have been removed and added some checks, `checkParamInRange` to throw a Defect if the value passed is not in the range they should be in.
aruZeta
force-pushed
the
feature/custom-module-sep/1
branch
from
e3186f9
to
3321ff2
Compare
Well, by default the value is 0.1 when drawing rounded modules, so there is no need to actually set it to 0 or anything, this way there is no need to check what the passed value is or if `moRad` and `forceUseRect` are whatever value, since anyway `moSep` is only used when one of both fit the same conditions in the first if of the func's body.
aruZeta
force-pushed
the
feature/custom-module-sep/1
branch
from
3321ff2
to
042ac0a
Compare
aruZeta
added
feature
|
I think it might be a better idea to set the separation to be a |
|
Opened #29 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.