Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: make moSep a Percentage #29

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

aruZeta
Copy link
Owner

@aruZeta aruZeta commented Sep 15, 2022

I think this is more intuitive.

Note:

0% moSep means 0 margin, so the width of a module is 1.
100% moSep means 0.4 margin, so the width of a module is 0.2.

Since I think it makes no sense to have 100% moSep to be 0.5 margin, making the width of a module non-existent.

@aruZeta aruZeta added feature This PR adds a new feature to the next major or minor release. breaking change This PR adds main API breaking changes to the next major release. labels Sep 15, 2022
@aruZeta aruZeta merged commit 6406662 into release/2.0.0 Sep 15, 2022
@aruZeta aruZeta mentioned this pull request Sep 15, 2022
3 tasks
@aruZeta aruZeta deleted the feature/custom-module-sep/2 branch September 15, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This PR adds main API breaking changes to the next major release. feature This PR adds a new feature to the next major or minor release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant