Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_recordings() - previously fun_aru_samp #23

Closed
steffilazerte opened this issue Feb 23, 2024 · 3 comments
Closed

sample_recordings() - previously fun_aru_samp #23

steffilazerte opened this issue Feb 23, 2024 · 3 comments

Comments

@steffilazerte
Copy link
Collaborator

This issue pertains to refactoring the function fun_aru_samp() to sample_recordings()

@steffilazerte
Copy link
Collaborator Author

Ah, hmm, I just realized that the original doesn't use real spatial data, but doy and t2sr/t2ss... whoops, I'll have to adjust that!

@steffilazerte
Copy link
Collaborator Author

@dhope These x/y coordinates... should they match those used in the initial selection weight calculations? If so, would it be worth appending that information somehow to the output of calc_selection_weights() (either as an attribute or extra column). And then it's pulled from the data in sample_recordings() so a user can't use one to create the selection weights, and then another on the actual selection?

@dhope
Copy link
Collaborator

dhope commented Feb 23, 2024

Yes, good catch. I can't think of a reasonable use case to modify them between weighting and selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants