Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trident support #13

Closed
nmoinvaz opened this issue Jan 8, 2019 · 2 comments
Closed

Trident support #13

nmoinvaz opened this issue Jan 8, 2019 · 2 comments

Comments

@nmoinvaz
Copy link
Contributor

nmoinvaz commented Jan 8, 2019

It appears that the script fails to load when using Trident/IE web browser control. The errors occurs at

ExplorerCanvas/excanvas.js

Line 51 in aa989ea

var IE_VERSION = +navigator.userAgent.match(/MSIE ([\d.]+)?/)[1];

In Trident, MSIE is not defined in the user agent and the return value for the match function is null. I'm not sure the IE_VERSION variable is used anywhere and maybe it can be removed.
@arv
Copy link
Owner

arv commented Jan 8, 2019

Doesn't look like it is being used anywhere.

Patches welcome

@nmoinvaz nmoinvaz mentioned this issue Feb 15, 2019
Merged
@nmoinvaz
Copy link
Contributor Author

Looks like there was an issue with the pull request. I have corrected it.

arv added a commit that referenced this issue Feb 20, 2019
@arv
Merge pull request #14 from nmoinvaz/fixes/undefined-trident
565afad 
Removed IE_VERSION variable due to undefined error on trident. #13
@arv arv closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arv @nmoinvaz