Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trident support #13

Closed
nmoinvaz opened this issue Jan 8, 2019 · 2 comments

Comments

@nmoinvaz
Copy link
Contributor

commented Jan 8, 2019

It appears that the script fails to load when using Trident/IE web browser control. The errors occurs at

var IE_VERSION = +navigator.userAgent.match(/MSIE ([\d.]+)?/)[1];

In Trident, MSIE is not defined in the user agent and the return value for the match function is null. I'm not sure the IE_VERSION variable is used anywhere and maybe it can be removed.

@arv

This comment has been minimized.

Copy link
Owner

commented Jan 8, 2019

Doesn't look like it is being used anywhere.

Patches welcome

nmoinvaz added a commit to nmoinvaz/ExplorerCanvas that referenced this issue Jan 8, 2019
@nmoinvaz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

Looks like there was an issue with the pull request. I have corrected it.

arv added a commit that referenced this issue Feb 20, 2019
Merge pull request #14 from nmoinvaz/fixes/undefined-trident
Removed IE_VERSION variable due to undefined error on trident. #13

@arv arv closed this Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.