Unhandled exception thrown by Boost.Asio

[glassez]

There are many crash reports in qBittorrent bug tracker that point to unhandled exception thrown in boost::asio::detail::socket_select_interrupter::open_descriptors. IIRC, exception is often thrown once some VPN service is enabled during qBittorrent run.

[glassez]

Yet another related crash report, but qBittorrent is crashed after hibernation: qbittorrent/qBittorrent#18823.

[xavier2k6]

@arvidn Going over chriskohlhoff/asio#1061 (comment) & chriskohlhoff/asio#1061 (comment) - I don't know if this is related/relevant but the only place left in libtorrent code that wasn't changed from async_receive to async_receive_from was in ip_notifier.cpp

libtorrent/src/ip_notifier.cpp

Line 155 in 6d64ac1

m_socket.async_receive(boost::asio::buffer(m_buf)

&

libtorrent/src/ip_notifier.cpp

Line 218 in 6d64ac1

m_socket.async_receive(boost::asio::buffer(m_buf)

What if there's a socket failure/error not properly being handled??

[xavier2k6]

@arvidn Reproducible steps in qbittorrent/qBittorrent#18811 (comment)

[xavier2k6]

@arvidn Ping

[xavier2k6]

I see you're prepping 2.0.9 / 1.2.19 for release, would a fix for this issue make it in to these versions by any chance?

[arvidn]

I don't believe there is a fix

[arvidn]

I don't know if this is related/relevant but the only place left in libtorrent code that wasn't changed from async_receive to async_receive_from was in ip_notifier.cpp

Chris' comment was about using null_buffers instead of allocating the receive buffer up-front. In more recent versions of asio, null_buffers have been replaced by async_wait() on sockets. This is still done on the UDP socket.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[xavier2k6]

keep alive

[xavier2k6]

• 100% cpu when blocked by firewall #3311

First record/reference of issue with boost::asio::detail::socket_select_interrupter::open_descriptors

[xavier2k6]

We are still getting crash reports of this over at qBittorrent.

[arvidn]

I suspect I would need to not use async_wait() on sockets.

[xavier2k6]

Still getting crashes even with Boost 1.86.0