Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues about the online correction #137

Open
ronal9527 opened this issue Dec 13, 2022 · 1 comment
Open

Issues about the online correction #137

ronal9527 opened this issue Dec 13, 2022 · 1 comment

Comments

@ronal9527
Copy link

Hi,

Thanks for implementing this great package.
As I understand, the algorithm should find the elbow/knee where the maximum y_difference is.
However, when I test this algorithm is in 'online' mode (for an increasing convex curve), it tends to find the elbow where the last local maximum y_difference is. (shown in the figure below). Since the original paper does go into details about the online correction, I wonder if this behaviour complies with the original algorithm.
图片1

@d-kleine
Copy link

d-kleine commented May 2, 2023

Without the data and/or code provided, it's hard to help you with that. For the online setting, have you used a sensitivity of 1, as in the paper suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants