Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Skylink fix #78

Merged
merged 8 commits into from
Nov 29, 2019
Merged

Skylink fix #78

merged 8 commits into from
Nov 29, 2019

Conversation

arvvoid
Copy link
Owner

@arvvoid arvvoid commented Nov 28, 2019

Please check that your pull request pass this checks:

  • My changes respect the Kodi add-on development rules
  • My code is both Python 2 and 3 compatible
  • My code follows the code style of this project
  • I made sure there wasn't another Pull Request opened for the same update/change
  • I have successfully tested my changes locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Adding a new region/hbo go version

Description:

This should fix Skylink CZ and Slovakia operator based on @ferdabasek code, the code is ready for merging after testing.

Linked to ISSUE #5

@arvvoid arvvoid self-assigned this Nov 28, 2019
@arvvoid arvvoid added this to the v.2.0.EU milestone Nov 28, 2019
@arvvoid arvvoid added bug Something isn't working enhancement New feature or request WIP Work in Progress Testers wanted labels Nov 28, 2019
changelog.md Outdated Show resolved Hide resolved
addon.xml Outdated Show resolved Hide resolved
@arvvoid
Copy link
Owner Author

arvvoid commented Nov 28, 2019

@durip
Copy link

durip commented Nov 28, 2019

everything is working lika a charm :)
OSMC Kodi 18.5

@ferdabasek
Copy link

  • fix works on KODI 18.5.
  • on KODI 19.0. - ALPHA1 plugin cannot run

kodi.log

obrazek

@arvvoid
Copy link
Owner Author

arvvoid commented Nov 29, 2019

@ferdabasek Tnx for testing. Yes on Kodi 19 Python3 Windows Build this is expected since pycryptodome is broken in that build (https://forum.kodi.tv/showthread.php?tid=348495, https://forum.kodi.tv/showthread.php?tid=348400).
For Kodi 19 Python3 testing of this add-on (or any add-on having cryptodome as a dependency) until this is fixed in the Kodi 19 Windows build only MacOS or Linux builds that use the system Python3 installation is possible (is just necessary to install pycryptodomex on the system using pip). It might work on the Android Kodi 19 test build but didn't try that one so idk if its reliable for testing.
A LibreElec test build with Kodi 19 Python3 exist as well I think.

But these changes should work fine on Python3.

@arvvoid arvvoid removed the WIP Work in Progress label Nov 29, 2019
@arvvoid
Copy link
Owner Author

arvvoid commented Nov 29, 2019

I think this is ready for merging if any minor issue comes up at a later time can be easily fixed.

Since this prevents the add-on to be used by many users will speed things up merge and push a new release soon.

@arvvoid arvvoid merged commit 120e585 into master Nov 29, 2019
@arvvoid arvvoid deleted the Skylink_fix branch November 29, 2019 13:08
@arvvoid arvvoid restored the Skylink_fix branch November 29, 2019 13:17
@arvvoid
Copy link
Owner Author

arvvoid commented Nov 29, 2019

Fix included in latest release: https://github.com/arvvoid/plugin.video.hbogoeu/releases

@arvvoid arvvoid deleted the Skylink_fix branch November 29, 2019 13:18
@arvvoid arvvoid removed this from the v.2.0.EU milestone Dec 10, 2019
@arvvoid arvvoid added this to the V.2.1.EU milestone Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request Testers wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants