Fix #10517. before() and after() on disconnected node should return m…

…ultiple nodes. Closes jquerygh-851.
asad-shmoghadam · Jul 10, 2012 · f843a70 · f843a70
1 parent b6cb4b4
commit f843a70
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -142,7 +142,7 @@ jQuery.fn.extend({
 	},
 
 	before: function() {
-		if ( this[0] && this[0].parentNode ) {
+		if ( !isDisconnected( this[0] ) ) {
 			return this.domManip(arguments, false, function( elem ) {
 				this.parentNode.insertBefore( elem, this );
 			});
@@ -155,7 +155,7 @@ jQuery.fn.extend({
 	},
 
 	after: function() {
-		if ( this[0] && this[0].parentNode ) {
+		if ( !isDisconnected( this[0] ) ) {
 			return this.domManip(arguments, false, function( elem ) {
 				this.parentNode.insertBefore( elem, this.nextSibling );
 			});
@@ -259,7 +259,7 @@ jQuery.fn.extend({
 	},
 
 	replaceWith: function( value ) {
-		if ( this[0] && this[0].parentNode && this[0].parentNode.nodeType != 11 ) {
+		if ( !isDisconnected( this[0] ) ) {
 			// Make sure that the elements are removed from the DOM before they are inserted
 			// this can help fix replacing a parent with child elements
 			if ( jQuery.isFunction( value ) ) {

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -917,6 +917,13 @@ test("before and after w/ empty object (#10812)", function() {
 	equal( res.wrapAll("<div/>").parent().text(), "()", "correctly appended text" );
 });
 
+test("before and after on disconnected node (#10517)", function() {
+	expect(2);
+
+	equal( jQuery("<input type='checkbox'/>").before("<div/>").length, 2, "before() returned all elements" );
+	equal( jQuery("<input type='checkbox'/>").after("<div/>").length, 2, "after() returned all elements" );
+});
+
 test("insertBefore(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 	expect(4);
 	var expected = "This is a normal link: bugaYahoo";