Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved callback handler - RPC #80

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Improved callback handler - RPC #80

merged 3 commits into from
Jun 6, 2024

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented Jun 5, 2024 •
edited
Loading

Swapped RPC register callbacks with CallBackManager

@momintlh momintlh changed the title Improved callback handler Improved callback handler - RPC Jun 5, 2024
SaadBazaz
SaadBazaz approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If looks alright after resolving the comment, go ahead for merge.
Can improve as we go. Just ensure this is fully tested.

@momintlh momintlh merged commit 38b3130 into main Jun 6, 2024
2 checks passed
@SaadBazaz SaadBazaz mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadBazaz SaadBazaz SaadBazaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momintlh @SaadBazaz