Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockMode V2 #81

Merged
merged 4 commits into from
Jun 13, 2024
Merged

MockMode V2 #81

merged 4 commits into from
Jun 13, 2024

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented Jun 11, 2024 •
edited
Loading

  • Separated out JS functions definitions in another file.
  • Separated out Mock mode
  • Added RPC mock-mode!

resolves #71 and related #40

@momintlh momintlh requested a review from SaadBazaz June 12, 2024 16:15
SaadBazaz
SaadBazaz reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Is this tested? Do multiple callbacks work in MOCK MODE?

@momintlh
Copy link
Collaborator Author

Is this tested? Do multiple callbacks work in MOCK MODE?

Yes, tested with multiple callbacks

@momintlh momintlh merged commit 7ef002b into main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadBazaz SaadBazaz SaadBazaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature-Request]: RPC mock mode
2 participants
@momintlh @SaadBazaz