Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to include time info in the session logs #603

Closed
popxunga opened this issue May 6, 2020 · 5 comments
Closed

An option to include time info in the session logs #603

popxunga opened this issue May 6, 2020 · 5 comments
Milestone

Comments

@popxunga
Copy link

popxunga commented May 6, 2020

Hi Asbru Team ..

It would be useful to have an option to include time information while writing the session logs.
Something like this:

YYYY-MM-DD HH:MM:SS log line 1
YYYY-MM-DD HH:MM:SS log line 2
...
YYYY-MM-DD HH:MM:SS log line n

Thanks in advance.

@hanspr
Copy link
Contributor

hanspr commented May 7, 2020

What do you need this for?

@popxunga
Copy link
Author

popxunga commented May 7, 2020

The inclusion of time information is always useful in any type of log file.
In my case, for example:
To determine the time I executed something when that time does not get recorded elsewhere;
To determine the amount of time needed to execute a set of actions.

@hanspr hanspr mentioned this issue May 14, 2020
@gfrenoy gfrenoy added this to the 6.3.0 milestone May 15, 2020
gfrenoy pushed a commit that referenced this issue May 15, 2020
Limitation: data arrives in chunks with escape sequences, sometimes the information is cut in odd places and only partial information arrives.  So eventually some timestamps will not end on a new line, but in between the text.   Or some escape sequences can not be cleaned correctly because the timestamp introduces patterns that were not in the original stream.
@popxunga
Copy link
Author

popxunga commented May 15, 2020

Hi @hanspr

Briefly tested it and it looks like that the timestamp is being written in the log on each keystroke, which I think its an unexpected behavior. Here is a portion of the log produced in my test:

image

By activating the remove control char's option in configuration, I guess the final result may be very good if the timestamp is not written on each keystroke as it looks.

Thanks for adding this functionality :-)

@hanspr
Copy link
Contributor

hanspr commented May 15, 2020

Yes you would have to leave with that, the information arrives in chunks and with the echo, I can no do anything about it.

The procedure received the strings in chunks (cut at any place) and the manipulation has to be short and none intrusive to avoid communication problems or delays.

@popxunga
Copy link
Author

No problem. I can leave with that.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants