Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of shader compilation #97

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Refactoring of shader compilation #97

merged 2 commits into from
Mar 16, 2024

Conversation

fall2019
Copy link
Member

@fall2019 fall2019 commented Mar 15, 2024 •
edited
Loading

Keep order of included shader files unchanged.
Put camera class and other common shader utils into one header file.

@fall2019 fall2019 added the enhancement refactoring or optimization label Mar 15, 2024
@fall2019 fall2019 requested a review from MomoDeve March 15, 2024 10:24
@fall2019 fall2019 self-assigned this Mar 15, 2024
@fall2019 fall2019 linked an issue Mar 15, 2024 that may be closed by this pull request
Refactoring of shader compilation #96
Closed
@fall2019 fall2019 mentioned this pull request Mar 15, 2024
Open
MomoDeve
MomoDeve approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@MomoDeve MomoDeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move common include into fragment. Overall fine

@fall2019 fall2019 enabled auto-merge (squash) March 15, 2024 18:42
@fall2019 fall2019 requested a review from MomoDeve March 15, 2024 19:02
@fall2019 fall2019 merged commit 2ec56eb into master Mar 16, 2024
1 check passed
@fall2019 fall2019 deleted the shader_compilation_refactoring branch March 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MomoDeve MomoDeve MomoDeve approved these changes

Assignees

@fall2019 fall2019

Labels
enhancement refactoring or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring of shader compilation
2 participants
@fall2019 @MomoDeve