Asciidoctor.js integration #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ysb33r
commented
Apr 14, 2019
•
ysb33r
commented
- Drop Asciidoctor compatibility task #343
- Support Asciidoctor.js as alternative engine #344
- Remove deprecated methods on AsciidoctorJ extension #352
ysb33r
force-pushed
the
asciidoctor.js
branch
2 times, most recently
from
749f673
to
6dc0bce
Compare
ysb33r
force-pushed
the
asciidoctor.js
branch
5 times, most recently
from
748a91f
to
2d40613
Compare
For cases where people just want to use diagram, but are comfortable to with the default verison they can just specificy `useDiagram()` on the extension.
In most cases the same working directory will be used for all tasks, but if a task has requires that differ from the global setup only in version a separate working directory will be used.
Moved all Nodejs work into `js.nodejs` subpackages. Created some base classes that are engine-agnostic in the `js.base` subpackage.
- Restore lost plugin property files - Cleanup codenarc warnings - Restore missing ProcessMode - Restore missing AsciidoctorRemoteExecutionException - Restore missing AsciidoctorBasePlugin - Restore missing KindleGenBasePlugin - Restore missing imports
All cases are extra spaces that occur in strings for build scripts. These are harmless and the warnings waster a lot of time for little benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.