Links doesn't work properly

[john-cj]

Example:

https://foo.bar/[this is foo site]

And here is how it will look inside VS Code:

As you see, the syntax highlighting isn't correct. Aslo, if you click this link, it will open incorrect address:

https://foo.bar/[this

[MatteoCampinoti94]

It's not caused by the extension, the error is in VSCode's uri recognition. You can test it by putting the same link into a new blank file (CTRL+N).

VSCode seems to recognize as link any uri identifier (file:, http:, etc...) followed by any non-space characters. Something like this I guess: (https?|file)://\S+

[john-cj]

@MatteoCampinoti94 Well, thank you. In this case I will post it in VS Code repository itself.

[MatteoCampinoti94]

👍

[john-cj]

microsoft/vscode#67022

[curiouslychase]

I was looking at the Sublime AsciiDoctor package (which is what I believe the current regex is "based off of") and the capture groups look different.

Submlime Regex: https://github.com/asciidoctor/sublimetext-asciidoc/blob/master/Syntaxes/Asciidoctor.tmLanguage#L1390-L1400

When I see links the highlighting captures everything to the apostrophe, including [, is it possible that the regex is greedily capturing incorrectly?

example in an asciidoc file:

- https://asciidoctor.org/docs/asciidoc-writers-guide/[AsciiDoc Writer's Guide]