Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new setting to configure the URL of the Kroki server #480

Open
rasmusmk opened this issue Dec 17, 2021 · 6 comments
Open

Add a new setting to configure the URL of the Kroki server #480

rasmusmk opened this issue Dec 17, 2021 · 6 comments
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement

Comments

@rasmusmk
Copy link

Possibility to send kroki generation to local server/port
and maybe a selection to use cloud if no local response

@frankbenoit
Copy link

I find this really important for use at work.
It is not acceptable by the company that internals go to a public server.
On the other hand, asciidoc is important for technical documentation.
To see e.g. plantuml in the preview, I use then AsciidocFx, mainly for this use case only.
The alternative, setting :kroki-server-url: in each document seems also not a good approach, nor does it work for me.
Please support this as a setting in the asciidoc vs code plugin.

@ggrossetie
Copy link
Member

Kroki is disabled by default and you can configure the server using the kroki-server-url attribute from the extension settings:

image

image

@ggrossetie
Copy link
Member

With the upcoming support of the Asciidoctor Config File, you will also be able to set the kroki-server-url attribute in an .asciidoctorconfig file. See: #636

@ggrossetie
Copy link
Member

I'm willing to provide a new setting to set the Kroki URL similar to what the Intellij IDEA plugin does:

image

@ggrossetie ggrossetie changed the title use local kroki server instead of the cloud Add a new setting to configure the URL of the Kroki server Oct 2, 2022
@ggrossetie
Copy link
Member

and maybe a selection to use cloud if no local response

I don't think that's a good idea for privacy reasons. As mentioned by @frankbenoit, it might not be acceptable to send diagrams to a public server.

@nolange
Copy link

nolange commented May 8, 2023

I would be welcoming this setting aswell, it should take preference over a ASCII Doctor Config file for the preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Disccussion on new features, projects, etc... ✨ enhancement
Projects
None yet
Development

No branches or pull requests

4 participants