Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Please do not install tests #1208

Closed
yurivict opened this issue Feb 21, 2018 · 6 comments
Closed

Please do not install tests #1208

yurivict opened this issue Feb 21, 2018 · 6 comments

Comments

@yurivict
Copy link

yurivict commented Feb 21, 2018

I am getting the message:

pkg-static: py27-searx-0.14.0 conflicts with py27-suds-jurko-0.6 (installs files into the same place).  Problematic file: /usr/local/lib/python2.7/site-packages/tests/__init__.py

There is no need to install tests; they only conflict with other packages that do the same.

Version 0.14.0.

@asciimoo
Copy link
Member

Do you use the debian packaged version of searx?

@yurivict
Copy link
Author

No, I am creating the FreeBSD port, and it can't be installing tests.

@josch
Copy link

josch commented Feb 21, 2018

In the Debian package we just patch searx to not install tests. In fact we don't install lots of things. Our full diff against setup.py reads:

diff --git a/setup.py b/setup.py
index 6466d1f..1b0ae30 100644
--- a/setup.py
+++ b/setup.py
@@ -51,23 +51,9 @@ setup(
     },
     package_data={
         'searx': [
-            'settings.yml',
-            '../README.rst',
-            '../requirements.txt',
-            '../requirements-dev.txt',
             'data/*',
             'plugins/*/*',
-            'static/*.*',
-            'static/*/*.*',
-            'static/*/*/*.*',
-            'static/*/*/*/*.*',
-            'static/*/*/*/*/*.*',
-            'templates/*/*.*',
-            'templates/*/*/*.*',
-            'tests/*',
-            'tests/*/*',
-            'tests/*/*/*',
-            'translations/*/*/*'
+            'translations/*/*/*.mo'
         ],
     },

@yurivict
Copy link
Author

yurivict commented Feb 21, 2018

I patched the upcoming FreeBSD package too. This bug is meant to "upstream" this, so that distros don't all need to patch.


BTW, settings.yml, templates are required files. You shouldn't have patched them away.

@josch
Copy link

josch commented Feb 21, 2018

We patch them out in Debian because:

  • settings.yml is a configuration file and thus belongs into /etc/searx. We also ship /usr/share/doc/searx/examples/settings.yml.gz

  • templates and static would be installed into /usr/lib/python3/dist-packages/searx if they were not commented out in setup.py. But those are static files which are not Python scripts and thus they belong to /usr/share/searx instead.

@yurivict
Copy link
Author

yurivict commented Feb 21, 2018

settings.yml is a configuration file and thus belongs into /etc/searx

Exactly: #1211

But those are static files which are not Python scripts and thus they belong to /usr/share/searx instead.

#1212

@unixfox unixfox closed this as completed Feb 8, 2021
@searx searx locked and limited conversation to collaborators Feb 8, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

5 participants