Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text underlining gets lost after conversion from .cast to .gif (it works in archived asciicast2gif) #22

Closed
amalota opened this issue Oct 10, 2022 · 2 comments

Comments

@amalota
Copy link

amalota commented Oct 10, 2022

To reproduce, do:

run asciinema rec --command='echo -e "\033[4mlolxd"' /tmp/bug_repro.cast that results in:

image

then run agg /tmp/bug_repro.cast /tmp/bug_repro.gifs that results in gif without underline:

bug_repro_croped

@amalota amalota changed the title Text underlining gets lost after conversion from .cast to .gif (it works in archived asciicast2gif) Text underlining gets lost after conversion from .cast to .gif (it works in archived asciicast2gif) Oct 10, 2022
@ku1ik
Copy link
Contributor

ku1ik commented Feb 6, 2023

Yep, agg currently doesn't render underline. Should be relatively easy to add though.

@ku1ik
Copy link
Contributor

ku1ik commented Feb 13, 2023

Meanwhile, there's actually alternative renderer implementation that you can use with --renderer resvg option which supports underline text.

@ku1ik ku1ik closed this as completed in e68bb44 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants