Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bob the Builder's list of Elixir builds instead of GitHub tags #64

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@dbernheisel
Copy link
Contributor

commented May 22, 2019

Use Bob the Builder's list of available builds instead of Elixir's GitHub tags.

This list is published at https://repo.hex.pm/builds/elixir/builds.txt. @ericmj I assume this is ok to use?

There are some differences:

  • anyone using 0.12.3 or earlier won't have their version show up anymore. But, using master now, running asdf install elixir 0.7.2 doesn't work anyway.
  • Bob the Builder builds a major.minor version as well as major.minor.patch which isn't helpful for asdf's use case to lock versions. I've stripped these from the output so they don't show up. I do this by removing any line that only has one . character.
  • RC versions now show up.
  • OTP versions now show up.
  • master now shows up.

Here's the diff of asdf list-all elixir output, between master and this branch:

-0.7.2
-0.8.0
-0.8.1
-0.8.2
-0.8.3
-0.9.0
-0.9.1
-0.9.2
-0.9.3
-0.10.0
-0.10.1
-0.10.2
-0.10.3
-0.11.0
-0.11.1
-0.11.2
-0.12.0
-0.12.1
-0.12.2
-0.12.3
 0.12.4
 0.12.5
 0.13.0
@@ -31,60 +11,210 @@
 0.15.0
 0.15.1
 1.0.0
+1.0.0-otp-17
+1.0.0-rc1
+1.0.0-rc1-otp-17
+1.0.0-rc2
+1.0.0-rc2-otp-17
 1.0.1
+1.0.1-otp-17
 1.0.2
+1.0.2-otp-17
 1.0.3
+1.0.3-otp-17
 1.0.4
+1.0.4-otp-17
 1.0.5
+1.0.5-otp-17
+1.0.5-otp-18
+1.1.0-rc.0
+1.1.0-rc.0-otp-17
+1.1.0-rc.0-otp-18
 1.1.0
+1.1.0-otp-17
+1.1.0-otp-18
 1.1.1
+1.1.1-otp-17
+1.1.1-otp-18
+1.2.0-rc.0
+1.2.0-rc.0-otp-18
+1.2.0-rc.1
+1.2.0-rc.1-otp-18
 1.2.0
+1.2.0-otp-18
 1.2.1
+1.2.1-otp-18
 1.2.2
+1.2.2-otp-18
 1.2.3
+1.2.3-otp-18
 1.2.4
+1.2.4-otp-18
 1.2.5
+1.2.5-otp-18
 1.2.6
+1.2.6-otp-18
 1.3.0-rc.0
+1.3.0-rc.0-otp-18
+1.3.0-rc.0-otp-19
 1.3.0-rc.1
+1.3.0-rc.1-otp-18
+1.3.0-rc.1-otp-19
 1.3.0
+1.3.0-otp-18
+1.3.0-otp-19
 1.3.1
+1.3.1-otp-18
+1.3.1-otp-19
 1.3.2
+1.3.2-otp-18
+1.3.2-otp-19
 1.3.3
+1.3.3-otp-18
+1.3.3-otp-19
 1.3.4
+1.3.4-otp-18
+1.3.4-otp-19
 1.4.0-rc.0
+1.4.0-rc.0-otp-18
+1.4.0-rc.0-otp-19
+1.4.0-rc.0-otp-20
 1.4.0-rc.1
+1.4.0-rc.1-otp-18
+1.4.0-rc.1-otp-19
+1.4.0-rc.1-otp-20
 1.4.0
+1.4.0-otp-18
+1.4.0-otp-19
 1.4.1
+1.4.1-otp-18
+1.4.1-otp-19
 1.4.2
+1.4.2-otp-18
+1.4.2-otp-19
 1.4.3
+1.4.3-otp-18
+1.4.3-otp-19
 1.4.4
+1.4.4-otp-18
+1.4.4-otp-19
 1.4.5
+1.4.5-otp-18
+1.4.5-otp-19
+1.4.5-otp-20
 1.5.0-rc.0
+1.5.0-rc.0-otp-18
+1.5.0-rc.0-otp-19
+1.5.0-rc.0-otp-20
 1.5.0-rc.1
+1.5.0-rc.1-otp-18
+1.5.0-rc.1-otp-19
+1.5.0-rc.1-otp-20
 1.5.0-rc.2
+1.5.0-rc.2-otp-18
+1.5.0-rc.2-otp-19
+1.5.0-rc.2-otp-20
 1.5.0
+1.5.0-otp-18
+1.5.0-otp-19
+1.5.0-otp-20
 1.5.1
+1.5.1-otp-18
+1.5.1-otp-19
+1.5.1-otp-20
 1.5.2
+1.5.2-otp-18
+1.5.2-otp-19
+1.5.2-otp-20
 1.5.3
+1.5.3-otp-18
+1.5.3-otp-19
+1.5.3-otp-20
 1.6.0-rc.0
+1.6.0-rc.0-otp-19
+1.6.0-rc.0-otp-20
 1.6.0-rc.1
+1.6.0-rc.1-otp-19
+1.6.0-rc.1-otp-20
 1.6.0
+1.6.0-otp-19
+1.6.0-otp-20
 1.6.1
+1.6.1-otp-19
+1.6.1-otp-20
 1.6.2
+1.6.2-otp-19
+1.6.2-otp-20
 1.6.3
+1.6.3-otp-19
+1.6.3-otp-20
 1.6.4
+1.6.4-otp-19
+1.6.4-otp-20
 1.6.5
+1.6.5-otp-19
+1.6.5-otp-20
+1.6.5-otp-21
 1.6.6
+1.6.6-otp-19
+1.6.6-otp-20
+1.6.6-otp-21
 1.7.0-rc.0
+1.7.0-rc.0-otp-19
+1.7.0-rc.0-otp-20
+1.7.0-rc.0-otp-21
+1.7.0-rc.0-otp-22
 1.7.0-rc.1
+1.7.0-rc.1-otp-19
+1.7.0-rc.1-otp-20
+1.7.0-rc.1-otp-21
+1.7.0-rc.1-otp-22
 1.7.0
+1.7.0-otp-19
+1.7.0-otp-20
+1.7.0-otp-21
+1.7.0-otp-22
 1.7.1
+1.7.1-otp-19
+1.7.1-otp-20
+1.7.1-otp-21
+1.7.1-otp-22
 1.7.2
+1.7.2-otp-19
+1.7.2-otp-20
+1.7.2-otp-21
+1.7.2-otp-22
 1.7.3
+1.7.3-otp-19
+1.7.3-otp-20
+1.7.3-otp-21
+1.7.3-otp-22
 1.7.4
+1.7.4-otp-19
+1.7.4-otp-20
+1.7.4-otp-21
+1.7.4-otp-22
 1.8.0-rc.0
+1.8.0-rc.0-otp-20
+1.8.0-rc.0-otp-21
+1.8.0-rc.0-otp-22
 1.8.0-rc.1
+1.8.0-rc.1-otp-20
+1.8.0-rc.1-otp-21
+1.8.0-rc.1-otp-22
 1.8.0
+1.8.0-otp-20
+1.8.0-otp-21
+1.8.0-otp-22
 1.8.1
+1.8.1-otp-20
+1.8.1-otp-21
+1.8.1-otp-22
 1.8.2
+1.8.2-otp-20
+1.8.2-otp-21
+1.8.2-otp-22
+master
+master-otp-20
+master-otp-21
+master-otp-22

Resolves #50

@ericmj

This comment has been minimized.

Copy link

commented May 22, 2019

I assume this is ok to use?

Yes 👍

@dbernheisel dbernheisel force-pushed the dbernheisel:db-use-bob-list branch from bc5dc3c to f12342b May 22, 2019

@dbernheisel

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@Stratus3D let me know if there's anything else I can help with on this or if you have thoughts.

@dbernheisel

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Also related #67

@danhper

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Thanks a lot and sorry for the delay. I would rather avoid relying on two different sources so let's go with hex.pm only.

@danhper danhper merged commit 6f81ccb into asdf-vm:master Jul 2, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Stratus3D

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thanks @danhper !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.