fix: Only display the "can't keep downloads" warning when asked to keep downloads #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiin
approved these changes
May 13, 2024
leobastiani
approved these changes
Jun 21, 2024
CodeReaper
approved these changes
Jul 5, 2024
|
Any ETA on merging this PR? Not critical, but it's there :) |
Stratus3D
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the warning which is intended to alert users that the download directory can't be kept only appears if they haven't asked for it to be. This fix just rearranges the logic a bit so that the warning instead only appears if the download directory should be kept, but can't be (because it doesn't exist).
Fixes: #1711