New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Color profiles (ICC) #1576

Closed
dacap opened this Issue Sep 25, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@dacap
Member

dacap commented Sep 25, 2017

There were an issue about this but I cannot find it. Anyway I'll start writing the list of task to do this here:


Review these issues:

@dacap dacap added the enhancement label Sep 25, 2017

@dacap dacap modified the milestones: v1.3, v1.2 Sep 25, 2017

@dacap dacap self-assigned this Sep 29, 2017

@mysterycoconut

This comment has been minimized.

mysterycoconut commented May 15, 2018

As a quick workaround on the Mac, I just changed skia_window_osx.mm line 340 to…

CGColorSpaceRef colorSpace = CGColorSpaceCreateWithName(kCGColorSpaceSRGB);

This basically interprets color data in the app as sRGB, and transforms it to the current display's profile on the fly (instead of the current behavior that assumed the color data was on the display's profile, and did not need any color transformation).

@dacap

This comment has been minimized.

Member

dacap commented May 27, 2018

Thanks for the tip @mysterycoconut, I'll take a look to this issue in these weeks.

@cloewen8

This comment has been minimized.

cloewen8 commented Sep 14, 2018

I recently ran into an issue with Affinity Designer improperly displaying a gif from Aseprite. It reported that a color profile was missing. Having Aseprite export with a color profile would help me out a lot!

@dacap

This comment has been minimized.

Member

dacap commented Oct 15, 2018

I'm already making some progress on this issue:

color-profile-preferences

sprite-properties-with-color-profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment