Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions for Skia and OS X #1097

Merged
merged 1 commit into from Apr 26, 2016

Conversation

tony
Copy link
Contributor

@tony tony commented Apr 26, 2016

See also: #1089 #1081

@@ -4,6 +4,7 @@
* [Get the source code](#get-the-source-code)
* [Dependencies](#dependencies)
* [Linux dependencies](#linux-dependencies)
* [Building Skia dependency](#building-skia-dependency-os-xlinuxbsd)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dacap
Copy link
Member

dacap commented Apr 26, 2016

This issue brings me a lot to think about. In one side we could explain all the possibilities (e.g. "you can use make, or ninja, or vs projects, etc.") and all the steps needed to use each alternative. On the other side we could just give a unique list of steps for "non-programmers".

What I think about this? It's quite a tricky situation.

Looking at the amount of recent issues reported to compile Aseprite, it seems that a very low percentage of (C++) programmers are trying to compile Aseprite. We're having a lot of noise with compilations issues.

At the moment, my preference is that INSTALL.md should be focused to programmers.

@tony
Copy link
Contributor Author

tony commented Apr 26, 2016

@dacap heh, yes. Ideally the issues should be for development related tasks (being a tracker), not Q&A. You wouldn't but a Q&A on bugzilla.

I've seen Google Groups used as a place to divert discussion for that.

You can use GitHub wiki for community-based documentation. skia keeps per-platform instructions in their repo on their website: https://github.com/google/skia/tree/master/site/user/quick

Looking at the amount of recent issues reported to compile Aseprite, it seems that a very low percentage of (C++) programmers are trying to compile Aseprite. We're having a lot of noise with compilations issues.

Someone being a C++ programmer, whatever standard that would be to you, wouldn't make everything inherently obvious and unambiguous. I had to go on an expedition to figure out why skia wouldn't build correctly for me, that the CMake can't be used to build without GPU support. So that I had to go grab depot_tools. You could blame it on me seeing a CMakeLists.txt and assuming it works - and not reading cmake/readme.md that says its only experimental.

Incorporate skia adds a big step to building aseprite, probably bigger than configuring and building aseprite itself. I think the increase in the issues is caused by the skia migration - and that docs are a way to decrease the noise.

@dacap
Copy link
Member

dacap commented Apr 26, 2016

I had to go on an expedition to figure out why skia wouldn't build correctly for me

Yes, me too, its build system is the most tricky part. Actually the only requirement for Aseprite is that GYP_DEFINES must be skia_gpu when you compile Skia. Anyway I've compiled Skia so many times that I don't even remember the original instructions or in which state is the official documentation, so my opinions are really biased.

Incorporate skia adds a big step to building aseprite, probably bigger than configuring and building aseprite itself. I think the increase in the issues is caused by the skia migration - and that docs are a way to decrease the noise.

Yeah. I was having the idea to clean up the whole INSTALL.md when I completely remove the Allegro back-end, but seeing the current state, I think you are right, we should add the "how to compile Skia" section in INSTALL (at least to reduce the number of future issue reports).

Could you please move the "skia" section at the end and add a subsection for OSX/Linux,etc? I'll write the Windows instructions then.

@dacap
Copy link
Member

dacap commented Apr 26, 2016

Also I'm seriously thinking that Ninja should be almost mandatory (if someone wants to use other build system, is because he/she knows about CMake)

@tony
Copy link
Contributor Author

tony commented Apr 26, 2016

Also I'm seriously thinking that Ninja should be almost mandatory (if someone wants to use other build system, is because he/she knows about CMake)

I concur, I'll update to reflect that.

@tony tony force-pushed the install-rewrite branch 2 times, most recently from 2a0d6a0 to 3652fc7 Compare April 26, 2016 22:34
@tony
Copy link
Contributor Author

tony commented Apr 26, 2016

@dacap how about now?

@dacap
Copy link
Member

dacap commented Apr 26, 2016

It's fine. I'll continue from here and see if I can make this even more simple. Thanks for the help @tony

@dacap dacap merged commit 9150b04 into aseprite:master Apr 26, 2016
@tony tony deleted the install-rewrite branch April 26, 2016 22:48
@tony
Copy link
Contributor Author

tony commented Apr 26, 2016

yeoopo

@dacap
Copy link
Member

dacap commented Apr 27, 2016

@tony I've just updated the INSTALL.md instructions with cab10fb if you can give it a look that would be great, I hope this helps reducing the number of issue reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants