New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions for Skia and OS X #1097
Conversation
@@ -4,6 +4,7 @@ | |||
* [Get the source code](#get-the-source-code) | |||
* [Dependencies](#dependencies) | |||
* [Linux dependencies](#linux-dependencies) | |||
* [Building Skia dependency](#building-skia-dependency-os-xlinuxbsd) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This issue brings me a lot to think about. In one side we could explain all the possibilities (e.g. "you can use make, or ninja, or vs projects, etc.") and all the steps needed to use each alternative. On the other side we could just give a unique list of steps for "non-programmers". What I think about this? It's quite a tricky situation. Looking at the amount of recent issues reported to compile Aseprite, it seems that a very low percentage of (C++) programmers are trying to compile Aseprite. We're having a lot of noise with compilations issues. At the moment, my preference is that INSTALL.md should be focused to programmers. |
@dacap heh, yes. Ideally the issues should be for development related tasks (being a tracker), not Q&A. You wouldn't but a Q&A on bugzilla. I've seen Google Groups used as a place to divert discussion for that. You can use GitHub wiki for community-based documentation. skia keeps per-platform instructions in their repo on their website: https://github.com/google/skia/tree/master/site/user/quick
Someone being a C++ programmer, whatever standard that would be to you, wouldn't make everything inherently obvious and unambiguous. I had to go on an expedition to figure out why skia wouldn't build correctly for me, that the CMake can't be used to build without GPU support. So that I had to go grab depot_tools. You could blame it on me seeing a Incorporate skia adds a big step to building aseprite, probably bigger than configuring and building aseprite itself. I think the increase in the issues is caused by the skia migration - and that docs are a way to decrease the noise. |
Yes, me too, its build system is the most tricky part. Actually the only requirement for Aseprite is that
Yeah. I was having the idea to clean up the whole Could you please move the "skia" section at the end and add a subsection for OSX/Linux,etc? I'll write the Windows instructions then. |
Also I'm seriously thinking that Ninja should be almost mandatory (if someone wants to use other build system, is because he/she knows about CMake) |
I concur, I'll update to reflect that. |
2a0d6a0
to
3652fc7
Compare
@dacap how about now? |
It's fine. I'll continue from here and see if I can make this even more simple. Thanks for the help @tony |
yeoopo |
See also: #1089 #1081