Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation extrude option export sprite sheet #1978

Closed

Conversation

dncampo
Copy link
Contributor

@dncampo dncampo commented Jan 10, 2019

Extrude algorithm implementation for "Export Sprite Sheet" option

dncampo and others added 10 commits January 4, 2019 14:46
In this first approach, the extrude capability is reached.
The solution is as follows:
There is one render for each edge band (top, bottom, left, right)
There is one render for each corner
There is one render for the original sprite image.
There are 9 render calls in total
Array approach that make easier to follow the algorithm
In this commit a minor refactor is made (swap 'for' order) and a detailed comment of algorithm is added.
Fix source bounds origin used to render a sample with trim+extrude
- the renderSample function was called twice instead of one.
- the meta-data (JSON) was not properly generated when extrude (displacement and size)
@dacap dacap self-requested a review January 10, 2019 01:21
@dacap dacap self-assigned this Jan 10, 2019
@dacap dacap added this to the v1.2 milestone Jan 10, 2019
dacap pushed a commit that referenced this pull request Jan 10, 2019
Merged #1978 (squashed). The only solved conflict was that now
ExportSpriteSheet use params, so we've added the "extrude" param to
ExportSpriteSheetParams.
@dacap
Copy link
Member

dacap commented Jan 10, 2019

Merged in cf1711c 👍

@dacap dacap closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants